Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15438 )
Change subject: [subprocess] copy subprocess JAR to be next to the master binary ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15438/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15438/3//COMMIT_MSG@10 PS3, Line 10: So that it can be found even with the default value of gflag : as 'ranger_jar_path'. The same for the hms JAR. > +1 to Andrew's comments. AFAICT this is only for testing. In production, th I suggested we change from a link to a copy. I thought this would be useful to reduce the coupling from the Java build and the C++ build. If I am running C++ tests and doing Java work at the same time, the Java build could remove the linked jar. I also thought this would be better for production scenarios given we only deliver a source release and default with the expectation that the jar is next to the binary. We actually used to use a copy for the hms-plugin.jar and our documentation describes finding the jar next to the binaries. I assume we would do the same for this jar. https://github.com/apache/kudu/blame/master/docs/hive_metastore.adoc#L155 -- To view, visit http://gerrit.cloudera.org:8080/15438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bab628fa2d1fbb8d9edee32b480c30da2756cdc Gerrit-Change-Number: 15438 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 16 Mar 2020 13:19:31 +0000 Gerrit-HasComments: Yes
