Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15438 )
Change subject: [subprocess] copy subprocess JAR to be next to the master binary ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15438/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15438/3//COMMIT_MSG@10 PS3, Line 10: So that it can be found even with the default value of gflag : as 'ranger_jar_path'. The same for the hms JAR. > OK, this explanation makes sense to me. Hao, could you summarize it and add Ack. For updating the gradle output directly to the bin dir, I keep the current behavior, as I don't see a strong reason to change it (which probably would require some custom changes in subprocess gradle build). Or do you have a strong opinion against it? http://gerrit.cloudera.org:8080/#/c/15438/3/src/kudu/hms/CMakeLists.txt File src/kudu/hms/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/15438/3/src/kudu/hms/CMakeLists.txt@70 PS3, Line 70: COMMAND cp > Should probably use 'cp -f' here. Same for the subprocess JAR. Done -- To view, visit http://gerrit.cloudera.org:8080/15438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bab628fa2d1fbb8d9edee32b480c30da2756cdc Gerrit-Change-Number: 15438 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 16 Mar 2020 23:32:29 +0000 Gerrit-HasComments: Yes
