Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15438 )
Change subject: [subprocess] copy subprocess JAR to be next to the master binary ...................................................................... Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/15438/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15438/3//COMMIT_MSG@10 PS3, Line 10: nstead of linking. It can reduce the coupling from the Java : build and the C++ build, since the Java build c > Ack. For updating the gradle output directly to the bin dir, I keep the cur It's a similar point about decoupling: if we build C++, doesn't it write over whatever JAR exists in the Java build directory? Not sure that makes a difference with running tests though in the same way that linking affects the C++ tests. I don't feel strongly about it. -- To view, visit http://gerrit.cloudera.org:8080/15438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bab628fa2d1fbb8d9edee32b480c30da2756cdc Gerrit-Change-Number: 15438 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 16 Mar 2020 23:54:25 +0000 Gerrit-HasComments: Yes
