Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15438 )
Change subject: [subprocess] copy subprocess JAR to be next to the master binary ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15438/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15438/3//COMMIT_MSG@10 PS3, Line 10: So that it can be found even with the default value of gflag : as 'ranger_jar_path'. The same for the hms JAR. > I suggested we change from a link to a copy. I thought this would be useful Yeah, that's a nice property of having this patch. OTOH one of the nice things about linking is that in iterating and updating the Java subprocess, I've found it handy that I don't have to rerun any make commands if I want to run some C++ subprocess tests with the new Java binary. That said, I don't feel strongly about it. If we do want to decouple the builds, would it make sense to have gradle output directly to the bin dir instead of copying? That seemed to be the original behavior of the HMS plugin since it used add_jar(). -- To view, visit http://gerrit.cloudera.org:8080/15438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bab628fa2d1fbb8d9edee32b480c30da2756cdc Gerrit-Change-Number: 15438 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 16 Mar 2020 18:28:43 +0000 Gerrit-HasComments: Yes
