Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15374 )
Change subject: KUDU-3079 Add MiniPostgres ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/15374/9/src/kudu/ranger/mini_postgres.cc File src/kudu/ranger/mini_postgres.cc: http://gerrit.cloudera.org:8080/#/c/15374/9/src/kudu/ranger/mini_postgres.cc@153 PS9, Line 153: db.Start()); > By default it logs to stderr, but it can be configured to log to file. stde It would be nice to config to log to the data root dir of minipostgres, similar to other services, as that is where we expect to find the log normally. http://gerrit.cloudera.org:8080/#/c/15374/9/src/kudu/ranger/mini_postgres.cc@157 PS9, Line 157: : Status MiniPostgres > I'm not sure what you mean. Do you think the min_wal_size should be set low Yeah, mostly about the size of min_wal_size and max_wal_size. Will it ever reach the maximum size? If so, can it be too large that affects other concurrent running tests? Similarly for min_wal_size, do we need 80MB as a minimal wal size? http://gerrit.cloudera.org:8080/#/c/15374/11/src/kudu/ranger/mini_postgres.cc File src/kudu/ranger/mini_postgres.cc: http://gerrit.cloudera.org:8080/#/c/15374/11/src/kudu/ranger/mini_postgres.cc@52 PS11, Line 52: The kernel won't assign this port until it's in : // this state but it can still be used by binding it explicitly. Not quite following this. 'until it's in this state' refer to which state? TIME_WAIT? http://gerrit.cloudera.org:8080/#/c/15374/11/src/kudu/ranger/mini_postgres.cc@160 PS11, Line 160: postgresql.conf This is the default configuration provided by postgresql? If so, can you add a comment. -- To view, visit http://gerrit.cloudera.org:8080/15374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba40126aa60e0ecbc5ae10cc1328493194c345bc Gerrit-Change-Number: 15374 Gerrit-PatchSet: 11 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 20 Mar 2020 04:44:21 +0000 Gerrit-HasComments: Yes
