Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15374 )
Change subject: KUDU-3079 Add MiniPostgres ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/15374/6/src/kudu/ranger/mini_postgres.cc File src/kudu/ranger/mini_postgres.cc: http://gerrit.cloudera.org:8080/#/c/15374/6/src/kudu/ranger/mini_postgres.cc@102 PS6, Line 102: : JoinPathSegments(bin_dir_, "postgres/post > They should each get a new random port as the kernel won't assign the same Different miniclusters should get different directories by virtue of using GetTestDataDirectory() (assuming only one is started per test case). My concern was mainly around what happens if we bind to port 1234 in TestFoo's call to GetRandomPort(), we then write that to disk, and while we're writing, TestFoo is no longer bound to the port and so TestBar's call to GetRandomPort() binds to port 1234 too. Or do we have a guarantee from the kernel that in between GetRandomPort() and starting up postgres that other process won't bind to the same port? -- To view, visit http://gerrit.cloudera.org:8080/15374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba40126aa60e0ecbc5ae10cc1328493194c345bc Gerrit-Change-Number: 15374 Gerrit-PatchSet: 10 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 19 Mar 2020 19:53:22 +0000 Gerrit-HasComments: Yes
