Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 )
Change subject: [python] KUDU-2632 Add DATE type support ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/test_scanner.py File python/kudu/tests/test_scanner.py: http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/test_scanner.py@349 PS1, Line 349: self.assertEqual(types[0], np.int64) : self.assertEqual(types[1], 'datetime64[ns, UTC]') : self.assertEqual(types[2], np.object) : self.assertEqual(types[3], np.object) : self.assertEqual(types[4], np.bool) : self.assertEqual(types[5], np.float64) : self.assertEqual(types[6], np.int8) : self.assertEqual(types[7], np.object) : self.assertEqual(types[8], np.object) : self.assertEqual(types[9], np.float32) : else: : self.assertEqual(types[0], np.int64) : self.assertEqual(types[1], 'datetime64[ns, UTC]') : self.assertEqual(types[2], np.object) : self.assertEqual(types[3], np.bool) : self.assertEqual(types[4], np.float64) : self.assertEqual(types[5], np.int8) : self.assertEqual(types[6], np.object) : self.assertEqual(types[7], np.object) It seems this needs to be updated to accommodate for newly added columns of DATE type. -- To view, visit http://gerrit.cloudera.org:8080/15645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25 Gerrit-Change-Number: 15645 Gerrit-PatchSet: 1 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 04 Apr 2020 00:54:09 +0000 Gerrit-HasComments: Yes
