Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 )
Change subject: [python] KUDU-2632 Add DATE type support ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/util.py File python/kudu/tests/util.py: http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/util.py@112 PS1, Line 112: datetime.date(2020,1,1) For the sake of covering corner cases and making sure datetime.date() properly maps into the underlying types, does it make sense to add a scenario to write a rows with DATE column values of datetime.date(datetime.MINYEAR, 1, 1) datetime.date(datetime.MAXYEAR, 12, 31) ? -- To view, visit http://gerrit.cloudera.org:8080/15645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25 Gerrit-Change-Number: 15645 Gerrit-PatchSet: 1 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 04 Apr 2020 01:21:10 +0000 Gerrit-HasComments: Yes
