Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 )
Change subject: [python] KUDU-2632 Add DATE type support ...................................................................... Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/test_scanner.py File python/kudu/tests/test_scanner.py: http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/test_scanner.py@349 PS1, Line 349: self.assertEqual(types[0], np.int64) : self.assertEqual(types[1], 'datetime64[ns, UTC]') : self.assertEqual(types[2], np.object) : self.assertEqual(types[3], np.object) : self.assertEqual(types[4], np.bool) : self.assertEqual(types[5], np.float64) : self.assertEqual(types[6], np.int8) : self.assertEqual(types[7], np.object) : self.assertEqual(types[8], np.object) : self.assertEqual(types[9], np.object) : self.assertEqual(types[10], np.float32) : else: : self.assertEqual(types[0], np.int64) : self.assertEqual(types[1], 'datetime64[ns, UTC]') : self.assertEqual(types[2], np.object) : self.assertEqual(types[3], np.bool) : self.assertEqual(types[4], np.float64) : self.assertEqual(types[5], np.int8) : self.assertEqual(types[6], np.object) > It seems this needs to be updated to accommodate for newly added columns of Done http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py File python/kudu/util.py: http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@186 PS1, Line 186: Convert > If following the same style of the docs as for the other functions in this Done http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@188 PS1, Line 188: of seconds per day (86400). > nit: add a period Done http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@189 PS1, Line 189: > extra spaces Done http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@190 PS1, Line 190: Parameters > Could you add information about the parameter of this function into the doc Done http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@198 PS1, Line 198: """ > Convert Done http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@199 PS1, Line 199: return datetime.datetime.utcfromtimestamp(ndays * 86400).date() > nit: add a period Done http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@203 PS1, Line 203: Convert d > Is this a mismatch between the actual name of the parameter and the documen Done -- To view, visit http://gerrit.cloudera.org:8080/15645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25 Gerrit-Change-Number: 15645 Gerrit-PatchSet: 3 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Mon, 06 Apr 2020 16:53:20 +0000 Gerrit-HasComments: Yes
