Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 )
Change subject: [python] KUDU-2632 Add DATE type support ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/tests/test_scanner.py File python/kudu/tests/test_scanner.py: http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/tests/test_scanner.py@a365 PS3, Line 365: What happened to types[8] here? Should the change to be to add types[9]? http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/util.py File python/kudu/tests/util.py: http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/util.py@112 PS1, Line 112: datetime.date(2020,1,1) > I think for this kind of testing we just need to write tests for util funct This could be done in a follow up patch. http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/util.py File python/kudu/util.py: http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/util.py@201 PS3, Line 201: dat nit: date http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/util.py@208 PS3, Line 208: dat here too -- To view, visit http://gerrit.cloudera.org:8080/15645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25 Gerrit-Change-Number: 15645 Gerrit-PatchSet: 3 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Mon, 06 Apr 2020 23:24:38 +0000 Gerrit-HasComments: Yes
