Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15758 )
Change subject: [partitioning] KUDU-2671 Support for different hash partitioning per range partition. ...................................................................... Patch Set 3: (3 comments) I just did a quick first review pass. http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition-test.cc@894 PS3, Line 894: EXPECT_EQ(R"(HASH (k) PARTITION 0, RANGE (k) PARTITION 10 <= VALUES < 20)", : partition_schema.PartitionDebugString(partitions[0], (*range_hash_buckets)[0], schema)); : EXPECT_EQ(R"(HASH (k) PARTITION 1, RANGE (k) PARTITION 10 <= VALUES < 20)", : partition_schema.PartitionDebugString(partitions[1], (*range_hash_buckets)[0], schema)); > I thought the goal of this test was to test the ability to create range par +1 Also, what about a more 'synthetic' test where an actual table is created with range partitions having different number of hash buckets? After creating a table, it would be great to verify that appropriate number of tablets are created. Once a table is created, it's necessary to verify that a client is able to successfully write/read data from such a table. http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.h@150 PS3, Line 150: using RangeHashBuckets = boost::optional<std::vector<std::vector<HashBucketSchema>>>; > nit: I think it'd be more self-documenting and easier to immediately unders +1 for using boost::optional<> in function signatures and call sites. http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.h@151 PS3, Line 151: using RangeBounds Style nit: is there a reason to use 'using' instead of 'typedef' here? In most of other places like this, we tend to use 'typedef' for public type aliases unless it's an alias template. -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 3 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 22 Apr 2020 19:40:04 +0000 Gerrit-HasComments: Yes
