Volodymyr Verovkin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15758 )

Change subject: [partitioning] KUDU-2671 Support for different hash 
partitioning per range partition.
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.h
File src/kudu/common/partition.h:

http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.h@151
PS3, Line 151: using RangeBounds
> Style nit: is there a reason to use 'using' instead of 'typedef' here?  In
"using" is just "typedef" in C++11



--
To view, visit http://gerrit.cloudera.org:8080/15758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011
Gerrit-Change-Number: 15758
Gerrit-PatchSet: 3
Gerrit-Owner: Volodymyr Verovkin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin <[email protected]>
Gerrit-Comment-Date: Thu, 23 Apr 2020 23:48:46 +0000
Gerrit-HasComments: Yes

Reply via email to