Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15758 )
Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. ...................................................................... Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition-test.cc@894 PS3, Line 894: EXPECT_EQ(R"(HASH (k) PARTITION 0, RANGE (k) PARTITION 10 <= VALUES < 20)", : partition_schema.PartitionDebugString(partitions[0], (*range_hash_buckets)[0], schema)); : EXPECT_EQ(R"(HASH (k) PARTITION 1, RANGE (k) PARTITION 10 <= VALUES < 20)", : partition_schema.PartitionDebugString(partitions[1], (*range_hash_buckets)[0], schema)); > I thought the goal of this test was to test the ability to create range par Done http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition-test.cc@894 PS3, Line 894: EXPECT_EQ(R"(HASH (k) PARTITION 0, RANGE (k) PARTITION 10 <= VALUES < 20)", : partition_schema.PartitionDebugString(partitions[0], (*range_hash_buckets)[0], schema)); : EXPECT_EQ(R"(HASH (k) PARTITION 1, RANGE (k) PARTITION 10 <= VALUES < 20)", : partition_schema.PartitionDebugString(partitions[1], (*range_hash_buckets)[0], schema)); > +1 Done http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.h@150 PS3, Line 150: using RangeHashBuckets = boost::optional<std::vector<std::vector<HashBucketSchema>>>; > +1 for using boost::optional<> in function signatures and call sites. Done http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.h@150 PS3, Line 150: using RangeHashBuckets = boost::optional<std::vector<std::vector<HashBucketSchema>>>; > nit: I think it'd be more self-documenting and easier to immediately unders Done http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.h@151 PS3, Line 151: using RangeBounds > Style nit: is there a reason to use 'using' instead of 'typedef' here? In Done http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.h@151 PS3, Line 151: using RangeBounds > Exactly, and the ask here is to use 'typedef' here since we use it elsewher Done http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc@316 PS3, Line 316: PartitionSchema:: > nit: Don't need? Same elsewhere. Done http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc@368 PS3, Line 368: hash_bucket_schemas_ > If we are supposed to be using 'range_hash_buckets', why are we using 'hash Here we may have something like: // hash_bucket_schemas_ PARTITION BY HASH (id) PARTITIONS 4, RANGE (sku) ( //range_hash_buckets PARTITION VALUES < 'g' HASH PARTITIONS 2 -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 4 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Fri, 24 Apr 2020 03:16:28 +0000 Gerrit-HasComments: Yes
