Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15830 )
Change subject: [fs] fixed file num low live ratio metadata compaction policy when startup ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/15830/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15830/2//COMMIT_MSG@18 PS2, Line 18: consumptio nit: consumption http://gerrit.cloudera.org:8080/#/c/15830/2//COMMIT_MSG@20 PS2, Line 20: would help nit: remove. http://gerrit.cloudera.org:8080/#/c/15830/2//COMMIT_MSG@24 PS2, Line 24: Limit the num of metadata files to be compacted could help avoid OOM. Can you explain more about how this flag (which is to limit the number of metadata files to be compacted) can help avoid OOM? Ideally, wouldn't the more compaction of metadata files (number of metadata files decrease), the less the memory will be used? http://gerrit.cloudera.org:8080/#/c/15830/2/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/15830/2/src/kudu/fs/log_block_manager.cc@2631 PS2, Line 2631: FLAGS_max_num_low_live_ratio_metadata_file_to_compact > : lo nit: alignment. -- To view, visit http://gerrit.cloudera.org:8080/15830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifad1d6de4e61a1ddcfb35743abd71b57d6418896 Gerrit-Change-Number: 15830 Gerrit-PatchSet: 2 Gerrit-Owner: wangning <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 28 Apr 2020 23:08:29 +0000 Gerrit-HasComments: Yes
