Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15830 )
Change subject: [fs] limit memory could consume compacting low live ratio blocks during startup ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/15830/6//COMMIT_MSG Commit Message: PS6: Would it be possible to add a test for this? Maybe use CurrentConsumption() to periodically check the memory usage and see that it doesn't exceed some value. Have you verified that this new code works on a test server? http://gerrit.cloudera.org:8080/#/c/15830/4/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/15830/4/src/kudu/fs/log_block_manager.cc@2668 PS4, Line 2668: }); > Done I looked around the codebase a bit more and it seems like we use this kudu_malloc_usable_size(). I'm not sure it's exactly what we're looking for, but it'd be great if you could experiment a bit to see if it's appropriate to use, vs what we have now with the sizeof(). -- To view, visit http://gerrit.cloudera.org:8080/15830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifad1d6de4e61a1ddcfb35743abd71b57d6418896 Gerrit-Change-Number: 15830 Gerrit-PatchSet: 6 Gerrit-Owner: wangning <1994wangn...@gmail.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: wangning <1994wangn...@gmail.com> Gerrit-Comment-Date: Thu, 21 May 2020 22:36:59 +0000 Gerrit-HasComments: Yes
