wangning has posted comments on this change. ( http://gerrit.cloudera.org:8080/15830 )
Change subject: [fs] limit memory could consume compacting low live ratio blocks during startup ...................................................................... Patch Set 6: (8 comments) Thx for point out. My original purpose was to limit the memory. http://gerrit.cloudera.org:8080/#/c/15830/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15830/4//COMMIT_MSG@7 PS4, Line 7: [fs] limit memory could consume compacting low live ratio blocks during startup : > Also I think this would be a clearer: Change the commit to limit the memory may consume. http://gerrit.cloudera.org:8080/#/c/15830/4//COMMIT_MSG@10 PS4, Line 10: nd the memory behave is not under control of > nit: I wasn't sure what "low live ratio metadata" referred to. Could you al It refers to all blocks in low ratio blocks. Changed to a clearer title. http://gerrit.cloudera.org:8080/#/c/15830/4//COMMIT_MSG@11 PS4, Line 11: d_bytes. > nit: "control" with one 'l' Done http://gerrit.cloudera.org:8080/#/c/15830/4//COMMIT_MSG@16 PS4, Line 16: memory > nit: "exceed" Done http://gerrit.cloudera.org:8080/#/c/15830/4//COMMIT_MSG@30 PS4, Line 30: > nit: "exceeds" Done http://gerrit.cloudera.org:8080/#/c/15830/4/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/15830/4/src/kudu/fs/log_block_manager.cc@119 PS4, Line 119: "startup time"); > nit: can you put this up by log_container_live_metadata_before_compact_rati Done http://gerrit.cloudera.org:8080/#/c/15830/4/src/kudu/fs/log_block_manager.cc@120 PS4, Line 120: n > nit: spell out "number" Done http://gerrit.cloudera.org:8080/#/c/15830/4/src/kudu/fs/log_block_manager.cc@2668 PS4, Line 2668: }); > Looking at the definition of BlockRecordPB, it seems to have the following Done -- To view, visit http://gerrit.cloudera.org:8080/15830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifad1d6de4e61a1ddcfb35743abd71b57d6418896 Gerrit-Change-Number: 15830 Gerrit-PatchSet: 6 Gerrit-Owner: wangning <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: wangning <[email protected]> Gerrit-Comment-Date: Fri, 15 May 2020 03:23:51 +0000 Gerrit-HasComments: Yes
