Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15830 )
Change subject: [fs] fixed file num low live ratio metadata compaction policy when startup ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/15830/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15830/4//COMMIT_MSG@7 PS4, Line 7: [fs] fixed file num low live ratio metadata compaction policy when : startup > nit: keep the title on a single line Also I think this would be a clearer: "[fs] limit to the number of metadata file compactions done at startup" http://gerrit.cloudera.org:8080/#/c/15830/4/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/15830/4/src/kudu/fs/log_block_manager.cc@2668 PS4, Line 2668: low_live_ratio_metadata_to_compact_num_.Increment(); > Using the number of metadata files seems kind of odd, given it requires som Looking at the definition of BlockRecordPB, it seems to have the following members: ::google::protobuf::internal::InternalMetadataWithArena _internal_metadata_; ::google::protobuf::internal::HasBits<1> _has_bits_; mutable int _cached_size_; ::kudu::BlockIdPB* block_id_; ::google::protobuf::uint64 timestamp_us_; ::google::protobuf::int64 offset_; ::google::protobuf::int64 length_; int op_type_; Most of these seem like trivial types, so we might be able to use `sizeof(BlockRecordPB) + sizeof(BlockIdPB)` as the individual size of a record on the heap (i.e. per element in the vector). -- To view, visit http://gerrit.cloudera.org:8080/15830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifad1d6de4e61a1ddcfb35743abd71b57d6418896 Gerrit-Change-Number: 15830 Gerrit-PatchSet: 4 Gerrit-Owner: wangning <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: wangning <[email protected]> Gerrit-Comment-Date: Thu, 14 May 2020 05:56:33 +0000 Gerrit-HasComments: Yes
