Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16036 )
Change subject: WIP [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/16036/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16036/3//COMMIT_MSG@26 PS3, Line 26: TODO: > Trying to understand the reason before I make the change. Yeah, and it'd also be nice to make sure that the iterators we think are being used are actually being used. Something a bit more end-to-end (even if just a single non-replicated tablet test) would fit that bill. http://gerrit.cloudera.org:8080/#/c/16036/3/src/kudu/common/generic_iterators-test.cc File src/kudu/common/generic_iterators-test.cc: http://gerrit.cloudera.org:8080/#/c/16036/3/src/kudu/common/generic_iterators-test.cc@684 PS3, Line 684: public: > Moved the 2 public methods directly as part of the Test outside the class. Sounds good. I agree parameterization of the test is a must. I could live without the second, but don't feel strongly about it either way. http://gerrit.cloudera.org:8080/#/c/16036/3/src/kudu/common/generic_iterators.cc File src/kudu/common/generic_iterators.cc: http://gerrit.cloudera.org:8080/#/c/16036/3/src/kudu/common/generic_iterators.cc@1282 PS3, Line 1282: bool disableable_ineffective_predicate = : effectiveness_ctx != nullptr && !effectiveness_ctx->IsPredicateEnabled(); : // True: a disableable predicate that is determined to be effective. : // False: a non-disableable predicate or a disableable predicate that is determined to be : // ineffective. : bool disableable_effective_predicate = > Changed the names. Sure, but these are quite verbose, and I think add more cognitive overhead than summarizing the rules. E.g. // Indicate whether the predicate has been disabled or not. If the predicate is not disableable // (only bloom filter predicates are disableable), both of these are false. bool disableable_predicate_disabled = ...; bool disableable_predicate_enabled = ...; -- To view, visit http://gerrit.cloudera.org:8080/16036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10197800a01a1b34c7821ac879caf8d272cab8dd Gerrit-Change-Number: 16036 Gerrit-PatchSet: 3 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 12 Jun 2020 23:02:21 +0000 Gerrit-HasComments: Yes
