Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16036 )
Change subject: WIP [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/16036/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16036/3//COMMIT_MSG@14 PS3, Line 14: for every 16 blocks > Thanks for pointing that out. Done http://gerrit.cloudera.org:8080/#/c/16036/3//COMMIT_MSG@26 PS3, Line 26: TODO: > Yeah, and it'd also be nice to make sure that the iterators we think are be Done http://gerrit.cloudera.org:8080/#/c/16036/3/src/kudu/common/generic_iterators.cc File src/kudu/common/generic_iterators.cc: http://gerrit.cloudera.org:8080/#/c/16036/3/src/kudu/common/generic_iterators.cc@1282 PS3, Line 1282: bool disableable_ineffective_predicate = : effectiveness_ctx != nullptr && !effectiveness_ctx->IsPredicateEnabled(); : // True: a disableable predicate that is determined to be effective. : // False: a non-disableable predicate or a disableable predicate that is determined to be : // ineffective. : bool disableable_effective_predicate = > Sure, but these are quite verbose, and I think add more cognitive overhead Done -- To view, visit http://gerrit.cloudera.org:8080/16036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10197800a01a1b34c7821ac879caf8d272cab8dd Gerrit-Change-Number: 16036 Gerrit-PatchSet: 3 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 17 Jun 2020 16:41:21 +0000 Gerrit-HasComments: Yes
