Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16036 )
Change subject: [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter ...................................................................... Patch Set 6: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/16036/4/src/kudu/client/predicate-test.cc File src/kudu/client/predicate-test.cc: http://gerrit.cloudera.org:8080/#/c/16036/4/src/kudu/client/predicate-test.cc@1513 PS4, Line 1513: auto* included_predicate_clone = included_predicate->Clone(); > Thanks for these suggestions! Thanks for adding the test coverage! http://gerrit.cloudera.org:8080/#/c/16036/6/src/kudu/client/predicate-test.cc File src/kudu/client/predicate-test.cc: http://gerrit.cloudera.org:8080/#/c/16036/6/src/kudu/client/predicate-test.cc@1553 PS6, Line 1553: // TSAN builds timeout and fail on flushing with large number of rows. : if ((i % (kNumRows / 10)) == 0) { : ASSERT_OK(session->Flush()); : } Alternatively you can try just writing 100 rows or something tiny like that. Seems like the behavior should be the same regardless -- To view, visit http://gerrit.cloudera.org:8080/16036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10197800a01a1b34c7821ac879caf8d272cab8dd Gerrit-Change-Number: 16036 Gerrit-PatchSet: 6 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 23 Jun 2020 19:43:15 +0000 Gerrit-HasComments: Yes
