Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16340 )
Change subject: [master] KUDU-3182 Allow single master to specify --master_addresses ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16340/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16340/1//COMMIT_MSG@15 PS1, Line 15: Inorder nit: In order http://gerrit.cloudera.org:8080/#/c/16340/1/src/kudu/master/master_options-test.cc File src/kudu/master/master_options-test.cc: http://gerrit.cloudera.org:8080/#/c/16340/1/src/kudu/master/master_options-test.cc@57 PS1, Line 57: class MasterOptionsTest : public KuduTest { : }; Will existing masters be able to specify this flag and update their Raft configs? http://gerrit.cloudera.org:8080/#/c/16340/1/src/kudu/master/master_options.h File src/kudu/master/master_options.h: http://gerrit.cloudera.org:8080/#/c/16340/1/src/kudu/master/master_options.h@40 PS1, Line 40: NOT_FOUND nit: we usually refer to Status errors in TitleCase Also may return IllegalState -- To view, visit http://gerrit.cloudera.org:8080/16340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fe1bcd217d68f66db72c321397d596cba4224be Gerrit-Change-Number: 16340 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 14 Aug 2020 20:37:16 +0000 Gerrit-HasComments: Yes
