Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16340 )
Change subject: [master] KUDU-3182 Allow single master to specify --master_addresses ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16340/1/src/kudu/master/master_options-test.cc File src/kudu/master/master_options-test.cc: http://gerrit.cloudera.org:8080/#/c/16340/1/src/kudu/master/master_options-test.cc@57 PS1, Line 57: class MasterOptionsTest : public KuduTest { : }; > Will existing masters be able to specify this flag and update their Raft co No, the current change doesn't update Raft config for existing deployments by simply specifying this flag. I was thinking of keeping that separate using 2 possible options: - Add a RPC to allow updating config without any downtime - Use existing rewrite_raft_config tool to populate the last_known_addr field. Though this'll incur downtime. Though looking at the code more, like you mention, it should be possible to add 'last_known_addr' field in Raft config on kudu startup for existing deployments provided user has supplied the single master address. If customers use a config mgmt tool like Cloudera Manager then with updates with kudu startup script --master_addresses field will be populated and the kudu master restart after the upgrade will populate the 'last_known_addr' field. So technically this can't be considered additional downtime to add a field. One minor downside, I see, is that for every single master restart with --master_addresses field specified, Raft config will need to be checked for existence of the field. -- To view, visit http://gerrit.cloudera.org:8080/16340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fe1bcd217d68f66db72c321397d596cba4224be Gerrit-Change-Number: 16340 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 14 Aug 2020 22:09:53 +0000 Gerrit-HasComments: Yes
