Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16340 )
Change subject: [master] KUDU-3182 Allow single master to specify --master_addresses ...................................................................... Patch Set 1: (1 comment) > Patch Set 1: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/16340/1/src/kudu/master/master_options-test.cc File src/kudu/master/master_options-test.cc: http://gerrit.cloudera.org:8080/#/c/16340/1/src/kudu/master/master_options-test.cc@57 PS1, Line 57: class MasterOptionsTest : public KuduTest { : }; > > One minor downside, I see, is that for every single master restart with - Yeah, even with the proposed change discussed in this comment, bringing up single master with empty --master_addresses is still okay. Noted in the commit message. "To be compatible with existing deployments, specifying this flag for single master configurations is still optional and not required. If specified, it's used to set the 'last_known_addr' field in the master Raft configuration." -- To view, visit http://gerrit.cloudera.org:8080/16340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fe1bcd217d68f66db72c321397d596cba4224be Gerrit-Change-Number: 16340 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 15 Aug 2020 00:10:25 +0000 Gerrit-HasComments: Yes
