Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16340 )
Change subject: [master] KUDU-3182 Allow single master to specify --master_addresses ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16340/1/src/kudu/master/master_options-test.cc File src/kudu/master/master_options-test.cc: http://gerrit.cloudera.org:8080/#/c/16340/1/src/kudu/master/master_options-test.cc@57 PS1, Line 57: class MasterOptionsTest : public KuduTest { : }; > One minor downside, I see, is that for every single master restart with > --master_addresses field specified, Raft config will need to be checked for > existence of the field. Yeah, though I suppose we're already doing this checking anyway upon initial creation. Another thing worth thinking about: if we by default start persisting a single last_known_addr field, will older versions of Kudu still be able to start up properly? Even if we pass in an empty --master_addresses field? -- To view, visit http://gerrit.cloudera.org:8080/16340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fe1bcd217d68f66db72c321397d596cba4224be Gerrit-Change-Number: 16340 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 14 Aug 2020 23:10:26 +0000 Gerrit-HasComments: Yes
