Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16364 )
Change subject: KUDU-3184: Added null check ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16364/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16364/1//COMMIT_MSG@7 PS1, Line 7: Added null check Rather "Fix GetFQDN() when canonical name returned is null" Also add [net] context. http://gerrit.cloudera.org:8080/#/c/16364/1//COMMIT_MSG@11 PS1, Line 11: later end sentence with a period. Mention about hitting this issue on Mac OS. http://gerrit.cloudera.org:8080/#/c/16364/1/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: http://gerrit.cloudera.org:8080/#/c/16364/1/src/kudu/util/net/net_util.cc@36 PS1, Line 36: #include "i386/endian.h" > error: 'i386/endian.h' file not found [clang-diagnostic-error] Was this file recommended by iwyu on your Mac? It looks architecture specific best avoided or wrapped under some arch #ifdefs. Something seems off about these includes suggested. I'd suggest revert all header file changes and let iwyu on gerrit make any recommendations, if needed. -- To view, visit http://gerrit.cloudera.org:8080/16364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6bfc1a39175761e3a2f19280066cb1c8343fe79d Gerrit-Change-Number: 16364 Gerrit-PatchSet: 1 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 25 Aug 2020 23:18:32 +0000 Gerrit-HasComments: Yes
