Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16364 )
Change subject: KUDU-3184:Fix GetFQDN() when canonical name returns null [net] ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/16364/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16364/1//COMMIT_MSG@7 PS1, Line 7: ix GetFQDN() whe > Rather "Fix GetFQDN() when canonical name returned is null" Done http://gerrit.cloudera.org:8080/#/c/16364/1//COMMIT_MSG@11 PS1, Line 11: > end sentence with a period. Will add macOS comment after this build http://gerrit.cloudera.org:8080/#/c/16364/1/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: http://gerrit.cloudera.org:8080/#/c/16364/1/src/kudu/util/net/net_util.cc@36 PS1, Line 36: #include <boost/functional/hash/hash.hpp> > Was this file recommended by iwyu on your Mac? discarded this endian.h change, kept other changes -- To view, visit http://gerrit.cloudera.org:8080/16364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6bfc1a39175761e3a2f19280066cb1c8343fe79d Gerrit-Change-Number: 16364 Gerrit-PatchSet: 2 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 26 Aug 2020 00:24:02 +0000 Gerrit-HasComments: Yes
