Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16364 )
Change subject: KUDU-3184:Fix GetFQDN() when canonical name returns null [net] ...................................................................... Patch Set 3: (3 comments) Almost ready to do. Minor comments. http://gerrit.cloudera.org:8080/#/c/16364/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16364/3//COMMIT_MSG@7 PS3, Line 7: [net] The context [net] goes at the beginning of the summary line, either before or after the jira. http://gerrit.cloudera.org:8080/#/c/16364/3/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: http://gerrit.cloudera.org:8080/#/c/16364/3/src/kudu/util/net/net_util.cc@21 PS3, Line 21: #include <errno.h> It's recommended to use C++ header file when available. Try putting the cerrno file back to its original place. I bet IWYU won't complain then. http://gerrit.cloudera.org:8080/#/c/16364/3/src/kudu/util/net/net_util.cc@417 PS3, Line 417: I should have mentioned this earlier. Could you add a comment when/why ai_canonname could be null? -- To view, visit http://gerrit.cloudera.org:8080/16364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6bfc1a39175761e3a2f19280066cb1c8343fe79d Gerrit-Change-Number: 16364 Gerrit-PatchSet: 3 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 26 Aug 2020 17:04:55 +0000 Gerrit-HasComments: Yes
