Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16371 )
Change subject: Upgrade docs/site building tools ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/16371/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16371/1//COMMIT_MSG@13 PS1, Line 13: s the new dependencies are fairly : new, they require Ruby and Doxygen versions newer than what's included : by default on CentOS 7 I think this is okay given we plan to dockerize the docs/site build. http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc File README.adoc: http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc@324 PS1, Line 324: build it from source Can you link to the instructions? http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc@326 PS1, Line 326: devtoolset-8 We may require this for Kudu builds soon as well as I am working on bumping the minimum GCC version. http://gerrit.cloudera.org:8080/#/c/16371/1/docs/support/scripts/Gemfile File docs/support/scripts/Gemfile: http://gerrit.cloudera.org:8080/#/c/16371/1/docs/support/scripts/Gemfile@a26 PS1, Line 26: Does this mean Mac works again? http://gerrit.cloudera.org:8080/#/c/16371/1/docs/support/scripts/make_docs.sh File docs/support/scripts/make_docs.sh: http://gerrit.cloudera.org:8080/#/c/16371/1/docs/support/scripts/make_docs.sh@175 PS1, Line 175: set -x Did you intend to keep this? Should this be unset at any point? -- To view, visit http://gerrit.cloudera.org:8080/16371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe Gerrit-Change-Number: 16371 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 26 Aug 2020 13:46:42 +0000 Gerrit-HasComments: Yes
