Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16371 )

Change subject: Upgrade docs/site building tools
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc
File README.adoc:

http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc@324
PS1, Line 324: build it from source
> Can you link to the instructions?
Done


http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc@326
PS1, Line 326: devtoolset-8
> We may require this for Kudu builds soon as well as I am working on bumping
Cool, in that case, this won't even be an extra dependency. We should still 
document it until then though, right?


http://gerrit.cloudera.org:8080/#/c/16371/1/docs/support/scripts/Gemfile
File docs/support/scripts/Gemfile:

http://gerrit.cloudera.org:8080/#/c/16371/1/docs/support/scripts/Gemfile@a26
PS1, Line 26:
> Does this mean Mac works again?
Yes, added warnings that it must not be built on Mac for publishing


http://gerrit.cloudera.org:8080/#/c/16371/1/docs/support/scripts/make_docs.sh
File docs/support/scripts/make_docs.sh:

http://gerrit.cloudera.org:8080/#/c/16371/1/docs/support/scripts/make_docs.sh@175
PS1, Line 175: set -x
> Did you intend to keep this? Should this be unset at any point?
Done



--
To view, visit http://gerrit.cloudera.org:8080/16371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
Gerrit-Change-Number: 16371
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 16:18:52 +0000
Gerrit-HasComments: Yes

Reply via email to