Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16371 )
Change subject: Upgrade docs/site building tools ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc File README.adoc: http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc@326 PS1, Line 326: docs/_ and _ > Cool, in that case, this won't even be an extra dependency. We should still yep, agreed. http://gerrit.cloudera.org:8080/#/c/16371/2/README.adoc File README.adoc: http://gerrit.cloudera.org:8080/#/c/16371/2/README.adoc@306 PS2, Line 306: WARNING: As the default values for some configuration options differ between Mac : and Linux (e.g. file vs log block manager) and the configuration reference is : generated by running the binaries with `-help`, the documentation *MUST NOT* be : generated on Mac for publishing purposes, only for verification. Can you add this warning to the releasing doc too? -- To view, visit http://gerrit.cloudera.org:8080/16371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe Gerrit-Change-Number: 16371 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 26 Aug 2020 17:59:02 +0000 Gerrit-HasComments: Yes
