Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16371 )
Change subject: Upgrade docs/site building tools ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc File README.adoc: http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc@324 PS1, Line 324: ake_docs.sh` to gene > For macOS an alternative is to install doxygen along with graphiz from MacP Yea on Mac it works from Homebrew as well. My point is that in some cases (like on CentOS 7) we need to build from source and can't rely on the package manager as they ship an old version. http://gerrit.cloudera.org:8080/#/c/16371/3/docs/support/scripts/make_docs.sh File docs/support/scripts/make_docs.sh: http://gerrit.cloudera.org:8080/#/c/16371/3/docs/support/scripts/make_docs.sh@43 PS3, Line 43: != > Does '-ne' actually work against strings? No, it doesn't, you're right. Changed to "!=" -- To view, visit http://gerrit.cloudera.org:8080/16371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe Gerrit-Change-Number: 16371 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 26 Aug 2020 22:15:14 +0000 Gerrit-HasComments: Yes
