Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16372 )
Change subject: Fix C++ client API docs ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16372/3/src/kudu/client/scan_batch.h File src/kudu/client/scan_batch.h: http://gerrit.cloudera.org:8080/#/c/16372/3/src/kudu/client/scan_batch.h@214 PS3, Line 214: @param [micros_since_utc_epoch] val here and below: I guess this should have been @param [out] micros_since_utc_epoch ? I guess somewhat better alternative might be @param [out] val Placeholder for the result value: microseconds since Epoch. -- To view, visit http://gerrit.cloudera.org:8080/16372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I387be394d656a7614189148a39ff7dec76eb994d Gerrit-Change-Number: 16372 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 26 Aug 2020 18:28:07 +0000 Gerrit-HasComments: Yes
