Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16372 )
Change subject: Fix C++ client API docs ...................................................................... Patch Set 6: Code-Review+2 (3 comments) LGTM, just a few more nits that I didn't noticed during the first review. http://gerrit.cloudera.org:8080/#/c/16372/6/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/16372/6/src/kudu/client/client.h@1123 PS6, Line 1123: @note This method is experimental and may change or disappear in future. nit: maybe it makes sense to make this and warning at line 1173 uniform, i.e. have the same @note or @warning in both places. http://gerrit.cloudera.org:8080/#/c/16372/6/src/kudu/client/client.h@2438 PS6, Line 2438: /// @name Advanced/Unstable API : // : ///@{ : /// Modifier flags for the row format returned from the server. : /// nit: while you are here fixing those groups, maybe fix this one as well? At least, it would be great to have it uniformly corrected, so nobody would copy-and-paste this incorrect (I think) instance. http://gerrit.cloudera.org:8080/#/c/16372/6/src/kudu/client/scan_batch.h File src/kudu/client/scan_batch.h: http://gerrit.cloudera.org:8080/#/c/16372/6/src/kudu/client/scan_batch.h@135 PS6, Line 135: // nit: maybe, correct this to be three slashes? -- To view, visit http://gerrit.cloudera.org:8080/16372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I387be394d656a7614189148a39ff7dec76eb994d Gerrit-Change-Number: 16372 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 27 Aug 2020 07:01:49 +0000 Gerrit-HasComments: Yes
