Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16394 )
Change subject: KUDU-3185 Add table owner to web UI and tools ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/16394/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/16394/3/src/kudu/tools/kudu-tool-test.cc@5947 PS3, Line 5947: , static_cast<string>("") Is it possible to remove this argument or that's the only way to create a table with no owner? As I can see, CreateKuduTable() has a parameter by default, and I'd think that's how you create a table with no owner. http://gerrit.cloudera.org:8080/#/c/16394/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/16394/1/src/kudu/tools/tool_action_table.cc@237 PS1, Line 237: cout << "OWNER " << table->owner() << endl; > Sure, added a test case for describe. We don't have any testing for web UI I don't recall any automation for the web UI testing. -- To view, visit http://gerrit.cloudera.org:8080/16394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0791847b58925ec9818943c62fe4a1bc00359749 Gerrit-Change-Number: 16394 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 01 Sep 2020 18:28:10 +0000 Gerrit-HasComments: Yes
