Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16394 )
Change subject: KUDU-3185 Add table owner to web UI and tools ...................................................................... Patch Set 4: > Patch Set 3: -Code-Review > > Whoops, it seems the newly added test fails: > > /home/jenkins-slave/workspace/kudu-master/1/src/kudu/tools/kudu-admin-test.cc:1759 > Value of: stdout > Expected: has substring "(\n key INT32 NOT NULL,\n int_val INT32 NOT > NULL,\n string_val STRING NULLABLE,\n PRIMARY KEY (key)\n)\nRANGE (key) > (\n PARTITION UNBOUNDED\n)\nREPLICAS 1" > Actual: "TABLE TestTable (\n key INT32 NOT NULL,\n int_val INT32 NOT > NULL,\n string_val STRING NULLABLE,\n PRIMARY KEY (key)\n)\nRANGE (key) > (\n PARTITION UNBOUNDED\n)\nOWNER slave\nREPLICAS 1\n" (of type > std::string) Apparently we did have a test for describe table, just not in the file I was expecting it to be in. Updated the test and moved the no-owner case to kudu-admin-test as well. -- To view, visit http://gerrit.cloudera.org:8080/16394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0791847b58925ec9818943c62fe4a1bc00359749 Gerrit-Change-Number: 16394 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 01 Sep 2020 21:09:07 +0000 Gerrit-HasComments: No
