Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16394 )
Change subject: KUDU-3185 Add table owner to web UI and tools ...................................................................... Patch Set 4: > > Patch Set 3: -Code-Review > > > > Whoops, it seems the newly added test fails: > > > > /home/jenkins-slave/workspace/kudu-master/1/src/kudu/tools/kudu-admin-test.cc:1759 > > Value of: stdout > > Expected: has substring "(\n key INT32 NOT NULL,\n int_val > INT32 NOT NULL,\n string_val STRING NULLABLE,\n PRIMARY KEY > (key)\n)\nRANGE (key) (\n PARTITION UNBOUNDED\n)\nREPLICAS 1" > > Actual: "TABLE TestTable (\n key INT32 NOT NULL,\n > int_val INT32 NOT NULL,\n string_val STRING NULLABLE,\n > PRIMARY KEY (key)\n)\nRANGE (key) (\n PARTITION > UNBOUNDED\n)\nOWNER slave\nREPLICAS 1\n" (of type std::string) > > Apparently we did have a test for describe table, just not in the > file I was expecting it to be in. Updated the test and moved the > no-owner case to kudu-admin-test as well. Ah, indeed -- that's a test in other file, named the same as the newly introduced one in PS3. BTW, this time it seems IWYU isn't too happy: >>> Fixing #includes in >>> '/home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/ts_itest-base.cc' @@ -22,7 +22,6 @@ #include <ostream> #include <set> #include <string> -#include <type_traits> #include <unordered_map> #include <unordered_set> #include <utility> IWYU would have edited 1 fil -- To view, visit http://gerrit.cloudera.org:8080/16394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0791847b58925ec9818943c62fe4a1bc00359749 Gerrit-Change-Number: 16394 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 01 Sep 2020 21:22:45 +0000 Gerrit-HasComments: No
