Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16394 )
Change subject: KUDU-3185 Add table owner to web UI and tools ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/16394/5/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/16394/5/src/kudu/tools/tool_action_table.cc@237 PS5, Line 237: cout << "OWNER " << table->owner() << endl; > Nit: Should we omit this line all together if the owner is unset/empty? Hm not sure tbh. You can't create tables without an owner post-1.13, so only old tables can exist without owners. Maybe add something like "OWNER <none>" or something would make more sense to indicate that the table doesn't have an owner. Should I add it or should we leave it as an empty string? -- To view, visit http://gerrit.cloudera.org:8080/16394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0791847b58925ec9818943c62fe4a1bc00359749 Gerrit-Change-Number: 16394 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 02 Sep 2020 17:33:22 +0000 Gerrit-HasComments: Yes
