Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16530 )
Change subject: [tool] KUDU-2181 CLI for Raft ChangeConfig to add a master ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/16530/1/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/16530/1/src/kudu/tools/tool_action_master.cc@138 PS1, Line 138: (( nit: extra parens http://gerrit.cloudera.org:8080/#/c/16530/1/src/kudu/tools/tool_action_master.cc@465 PS1, Line 465: Add a master to the Raft configuration of the Kudu cluster nit: may be worth mentioning any assumptions we have, e.g. a healthy quorum exists, the new master is already running and has a special flag set, etc. -- To view, visit http://gerrit.cloudera.org:8080/16530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I507f301d1aba17327eb35728eed0d765e86ef4cc Gerrit-Change-Number: 16530 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 02 Oct 2020 17:51:39 +0000 Gerrit-HasComments: Yes
