Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16530 )
Change subject: [tool] KUDU-2181 CLI to add master ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/16530/2/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/16530/2/src/kudu/tools/tool_action_master.cc@196 PS2, Line 196: d master $0 to the cluster. Please fol > Like you mention, I want to avoid putting URLs in error messages as they ca Ack http://gerrit.cloudera.org:8080/#/c/16530/3/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/16530/3/src/kudu/tools/tool_action_master.cc@159 PS3, Line 159: RETURN_NOT_OK((proxy.SyncRpc<ListMastersRequestPB, ListMastersResponsePB>( : req, &resp, "ListMasters", &MasterServiceProxy::ListMastersAsync))); : : if (resp.has_error()) { : return StatusFromPB(resp.error().status()); : } > I'm curious what's the path forward if this returned an error due to some t I would expect those cases to be handled by the LeaderMasterProxy, which encapsulates leader-finding/retrying logic. -- To view, visit http://gerrit.cloudera.org:8080/16530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I507f301d1aba17327eb35728eed0d765e86ef4cc Gerrit-Change-Number: 16530 Gerrit-PatchSet: 4 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 05 Feb 2021 19:45:15 +0000 Gerrit-HasComments: Yes
