Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16530 )
Change subject: [tool] KUDU-2181 CLI to add master ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16530/1/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/16530/1/src/kudu/tools/tool_action_master.cc@138 PS1, Line 138: > nit: extra parens It's required else the RETURN_NOT_OK macro considers the template parameters as arguments and fails compilation. See similar issue with ListMasters() implementation on L155 http://gerrit.cloudera.org:8080/#/c/16530/1/src/kudu/tools/tool_action_master.cc@465 PS1, Line 465: it to be passed as a standard flag. > nit: may be worth mentioning any assumptions we have, e.g. a healthy quorum Done -- To view, visit http://gerrit.cloudera.org:8080/16530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I507f301d1aba17327eb35728eed0d765e86ef4cc Gerrit-Change-Number: 16530 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 01 Feb 2021 14:16:18 +0000 Gerrit-HasComments: Yes
