Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16530 )
Change subject: [tool] KUDU-2181 CLI to add master ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/16530/2/src/kudu/client/master_proxy_rpc.cc File src/kudu/client/master_proxy_rpc.cc: http://gerrit.cloudera.org:8080/#/c/16530/2/src/kudu/client/master_proxy_rpc.cc@288 PS2, Line 288: template class AsyncLeaderMasterRpc<AddMasterRequestPB, AddMasterResponsePB>; : template class AsyncLeaderMasterRpc<ChangeTServerStateRequestPB, ChangeTServerStateResponsePB>; : template class AsyncLeaderMasterRpc<CreateTableRequestPB, CreateTableResponsePB>; : template class AsyncLeaderMasterRpc<IsCreateTableDoneRequestPB, IsCreateTableDoneResponsePB>; : template class AsyncLeaderMasterRpc<DeleteTableRequestPB, DeleteTableResponsePB>; : template class AsyncLeaderMasterRpc<AlterTableRequestPB, AlterTableResponsePB>; : template class AsyncLeaderMasterRpc<IsAlterTableDoneRequestPB, IsAlterTableDoneResponsePB>; : template class AsyncLeaderMasterRpc<GetTableSchemaRequestPB, GetTableSchemaResponsePB>; : template class AsyncLeaderMasterRpc<GetTableLocationsRequestPB, GetTableLocationsResponsePB>; : template class AsyncLeaderMasterRpc<GetTabletLocationsRequestPB, GetTabletLocationsResponsePB>; : template class AsyncLeaderMasterRpc<GetTableStatisticsRequestPB, GetTableStatisticsResponsePB>; nit: if adding this in alphabetical order, it would be great to re-sort the already existing entries as such Thanks! http://gerrit.cloudera.org:8080/#/c/16530/2/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: PS2: If adding new tools, don't forget to update kudu-tool-test.cc to add a signature for the new tool. Also, kudu-admin-test.cc is the place to add a test for the newly added functionality. http://gerrit.cloudera.org:8080/#/c/16530/2/src/kudu/tools/tool_action_master.cc@150 PS2, Line 150: MonoDelta::FromSeconds(4); > Do you think it's worth making this configurable as a tool argument? +1: there is --timeout flag for other CLI tools http://gerrit.cloudera.org:8080/#/c/16530/2/src/kudu/tools/tool_action_master.cc@517 PS2, Line 517: add_master Maybe, just 'add' ? The context sub-item is already 'master'. Compare kudu master add vs kudu master add_master Alternatively, it might be a new action in the 'cluster' sub-tool. -- To view, visit http://gerrit.cloudera.org:8080/16530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I507f301d1aba17327eb35728eed0d765e86ef4cc Gerrit-Change-Number: 16530 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 02 Feb 2021 07:46:13 +0000 Gerrit-HasComments: Yes
