Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16661 )
Change subject: KUDU-1563. Add UPDATE_IGNORE and DELETE_IGNORE operations ...................................................................... Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16661/4/src/kudu/tablet/ops/write_op.cc File src/kudu/tablet/ops/write_op.cc: http://gerrit.cloudera.org:8080/#/c/16661/4/src/kudu/tablet/ops/write_op.cc@105 PS4, Line 105: case RowOperationsPB::INSERT: : case RowOperationsPB::INSERT_IGNORE: : InsertIfNotPresent(privileges, WritePrivilegeType::INSERT); : break; : case RowOperationsPB::UPSERT: : InsertIfNotPresent(privileges, WritePrivilegeType::INSERT); : InsertIfNotPresent(privileges, WritePrivilegeType::UPDATE); : break; : case RowOperationsPB::UPDATE: : case RowOperationsPB::UPDATE_IGNORE: : InsertIfNotPresent(privileges, WritePrivilegeType::UPDATE); : break; : case Row > I audited the code for any more missing RowOperationsPB usage. Found anothe We briefly chatted about this -- this means that INSERT_IGNORE ops currently don't require any privileges to go through. This patch is probably fine as is, but we should backport this to older versions. -- To view, visit http://gerrit.cloudera.org:8080/16661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11dfd06e8d4d22cf1097fe1ff01a1b97cafaf899 Gerrit-Change-Number: 16661 Gerrit-PatchSet: 6 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 27 Oct 2020 23:03:17 +0000 Gerrit-HasComments: Yes
