Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16661 )
Change subject: KUDU-1563. Add UPDATE_IGNORE and DELETE_IGNORE operations ...................................................................... Patch Set 7: (7 comments) http://gerrit.cloudera.org:8080/#/c/16661/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16661/4//COMMIT_MSG@9 PS4, Line 9: UPDATE_IGNORE o > nit here and below: maybe, use the same style for quotes for the beginning Done http://gerrit.cloudera.org:8080/#/c/16661/4//COMMIT_MSG@11 PS4, Line 11: primary key hav > would _not_ be raised? Reworded to be more clear. http://gerrit.cloudera.org:8080/#/c/16661/4/src/kudu/client/write_op.h File src/kudu/client/write_op.h: http://gerrit.cloudera.org:8080/#/c/16661/4/src/kudu/client/write_op.h@250 PS4, Line 250: virtual > nit here and below: drop 'virtual' -- it's not needed since this method is I will leave it this way for now since all the classes and methods in this class do this. We can clean it up in a follow on commit. http://gerrit.cloudera.org:8080/#/c/16661/4/src/kudu/common/row_operations.h File src/kudu/common/row_operations.h: http://gerrit.cloudera.org:8080/#/c/16661/4/src/kudu/common/row_operations.h@79 PS4, Line 79: // For UPDATE, UPDATE_IGNORE, DELETE, or DELETE_IGNORE, the row key. > nit: add a comma after DELETE_IGNORE? Done http://gerrit.cloudera.org:8080/#/c/16661/4/src/kudu/tablet/ops/write_op.cc File src/kudu/tablet/ops/write_op.cc: http://gerrit.cloudera.org:8080/#/c/16661/4/src/kudu/tablet/ops/write_op.cc@105 PS4, Line 105: case RowOperationsPB::INSERT: : case RowOperationsPB::INSERT_IGNORE: : InsertIfNotPresent(privileges, WritePrivilegeType::INSERT); : break; : case RowOperationsPB::UPSERT: : InsertIfNotPresent(privileges, WritePrivilegeType::INSERT); : InsertIfNotPresent(privileges, WritePrivilegeType::UPDATE); : break; : case RowOperationsPB::UPDATE: : case RowOperationsPB::UPDATE_IGNORE: : InsertIfNotPresent(privileges, WritePrivilegeType::UPDATE); : break; : case Row > To validate this, I applied the following diff: I enhanced a few of these tests to get coverage of all the ops in this patch. Ideally we would have a test that loops over all the enum values in RowOperationsPB and validates the handling to ensure we don't regress again but I couldn't figure out how to do that quickly so I punted on it for now. http://gerrit.cloudera.org:8080/#/c/16661/4/src/kudu/tablet/ops/write_op.cc@274 PS4, Line 274: metrics->insert_ignore_errors > BTW, is there a test coverage for the update_ignore_errors metrics? I coul I don't see tests for any of the op metrics. I will add some in a follow on. http://gerrit.cloudera.org:8080/#/c/16661/4/src/kudu/tablet/ops/write_op.cc@441 PS4, Line 441: break; > nit: since the introduction of INSERT_IGNORE, does it make sense to add a D Done -- To view, visit http://gerrit.cloudera.org:8080/16661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11dfd06e8d4d22cf1097fe1ff01a1b97cafaf899 Gerrit-Change-Number: 16661 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 28 Oct 2020 01:56:03 +0000 Gerrit-HasComments: Yes
