Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16661 )
Change subject: KUDU-1563. Add UPDATE_IGNORE and DELETE_IGNORE operations ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/16661/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16661/4//COMMIT_MSG@9 PS4, Line 9: `UPDATE_IGNORE' nit here and below: maybe, use the same style for quotes for the beginning and the end quote or drop the quotes at all? http://gerrit.cloudera.org:8080/#/c/16661/4//COMMIT_MSG@11 PS4, Line 11: would be raised would _not_ be raised? http://gerrit.cloudera.org:8080/#/c/16661/4/src/kudu/client/write_op.h File src/kudu/client/write_op.h: http://gerrit.cloudera.org:8080/#/c/16661/4/src/kudu/client/write_op.h@250 PS4, Line 250: virtual nit here and below: drop 'virtual' -- it's not needed since this method is an override for a virtual method in the base class http://gerrit.cloudera.org:8080/#/c/16661/4/src/kudu/common/row_operations.h File src/kudu/common/row_operations.h: http://gerrit.cloudera.org:8080/#/c/16661/4/src/kudu/common/row_operations.h@79 PS4, Line 79: // For UPDATE, UPDATE_IGNORE, DELETE, or DELETE_IGNORE the row key. nit: add a comma after DELETE_IGNORE? http://gerrit.cloudera.org:8080/#/c/16661/4/src/kudu/tablet/ops/write_op.cc File src/kudu/tablet/ops/write_op.cc: http://gerrit.cloudera.org:8080/#/c/16661/4/src/kudu/tablet/ops/write_op.cc@274 PS4, Line 274: metrics->update_ignore_errors BTW, is there a test coverage for the update_ignore_errors metrics? I could not find it in this changelist, but I might miss it. http://gerrit.cloudera.org:8080/#/c/16661/4/src/kudu/tablet/ops/write_op.cc@441 PS4, Line 441: if (op.error_ignored) { nit: since the introduction of INSERT_IGNORE, does it make sense to add a DCHECK(!op.error_ignored) here under the INSERT, UPSERT, UPDATE, and DELETE cases? -- To view, visit http://gerrit.cloudera.org:8080/16661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11dfd06e8d4d22cf1097fe1ff01a1b97cafaf899 Gerrit-Change-Number: 16661 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 27 Oct 2020 23:16:59 +0000 Gerrit-HasComments: Yes
