Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16681 )

Change subject: WIP: KUDU-1563 Support ignore operations in kudu-spark
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16681/2/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
File 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala:

http://gerrit.cloudera.org:8080/#/c/16681/2/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala@266
PS2, Line 266: insert-ignore
There is also `insert_ignore` at line 297.  What's the difference?

Also, is it possible to introduce some sort of constant for the operation types 
and use those in such cases?



--
To view, visit http://gerrit.cloudera.org:8080/16681
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4b4dc0ec996a88afead0f9da0024457e568b0f4
Gerrit-Change-Number: 16681
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 31 Oct 2020 00:55:48 +0000
Gerrit-HasComments: Yes

Reply via email to