Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16681 )
Change subject: KUDU-1563 Support ignore operations in kudu-spark ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/16681/3/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala: http://gerrit.cloudera.org:8080/#/c/16681/3/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala@289 PS3, Line 289: def testInsertIgnoreRowsWriteOption() { nit: maybe add a hint to future readers like, "Identical to the above test, but supporting ignore operations, ensuring we functionally support the same semantics. Also uses "insert_ignore" instead of "insert-ignore"" or something? Readers (myself included) may otherwise squint for a bit deciphering whether there are other meaningful differences with the above test. -- To view, visit http://gerrit.cloudera.org:8080/16681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4b4dc0ec996a88afead0f9da0024457e568b0f4 Gerrit-Change-Number: 16681 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 06 Nov 2020 07:54:27 +0000 Gerrit-HasComments: Yes
