Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16681 )
Change subject: KUDU-1563 Support ignore operations in kudu-spark ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/16681/5/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala: http://gerrit.cloudera.org:8080/#/c/16681/5/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala@247 PS5, Line 247: case "insert_ignore" => InsertIgnore nit: can you make the order of underscore and hyphen versions consistent? http://gerrit.cloudera.org:8080/#/c/16681/5/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: http://gerrit.cloudera.org:8080/#/c/16681/5/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@486 PS5, Line 486: "kudu.ignoreDuplicateRowErrors is deprecated and slow. Use the insert_ignore operation instead.") should we emit this warning even if it is not supported in the cluster? -- To view, visit http://gerrit.cloudera.org:8080/16681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4b4dc0ec996a88afead0f9da0024457e568b0f4 Gerrit-Change-Number: 16681 Gerrit-PatchSet: 5 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 09 Nov 2020 11:39:05 +0000 Gerrit-HasComments: Yes
