Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16681 )
Change subject: KUDU-1563 Support ignore operations in kudu-spark ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/16681/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: http://gerrit.cloudera.org:8080/#/c/16681/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@159 PS4, Line 159: transient lazy val supportsIgnoreOperations Does the '@transient' attribute mean that every worker calls this since this piece of information isn't serialized? I'm concerned that Kudu masters might be bombarded with those Ping() requests even when it would be enough to check for the presence of the IGNORE operations once. Maybe, it's worth making the supportsIgnoreOperations field serializable to spare Kudu masters of unneeded load? -- To view, visit http://gerrit.cloudera.org:8080/16681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4b4dc0ec996a88afead0f9da0024457e568b0f4 Gerrit-Change-Number: 16681 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 07 Nov 2020 18:03:15 +0000 Gerrit-HasComments: Yes
