Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16675 )
Change subject: KUDU-3210 Disable digest authn in FIPS mode ...................................................................... Patch Set 5: Code-Review+1 (2 comments) LGTM, just a question and one more nit. http://gerrit.cloudera.org:8080/#/c/16675/5/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/16675/5/src/kudu/server/webserver-test.cc@a118 PS5, Line 118: Just curious: are these two options are gone in a newer version? Are we need those for the changes introduced in https://github.com/apache/kudu/commit/d6a6b54b175032c7d13d231ef6d156ef9d0e3ab0 ? I guess these are not needed, but just in case it would be nice to double-check. http://gerrit.cloudera.org:8080/#/c/16675/5/src/kudu/server/webserver-test.cc@155 PS5, Line 155: return; Here and below: does it make sense to add a warning here about not actually running the test, something like we have for long running tests if KUDU_ALLOW_SLOW_TESTS is not set? -- To view, visit http://gerrit.cloudera.org:8080/16675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a446aa8d95a67658c727d3a6f85943d64c79ecf Gerrit-Change-Number: 16675 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 02 Nov 2020 20:18:59 +0000 Gerrit-HasComments: Yes
