Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16675 )

Change subject: KUDU-3210 Disable digest authn in FIPS mode
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16675/5/src/kudu/server/webserver.cc
File src/kudu/server/webserver.cc:

http://gerrit.cloudera.org:8080/#/c/16675/5/src/kudu/server/webserver.cc@280
PS5, Line 280: CHECK(!FIPS_mode())
As an option, what if the code returned State::IllegalState() from here -- it 
seems the signature of this method allows for this.  Would it be enough to 
prevent Kudu master and tablet server starting up?



--
To view, visit http://gerrit.cloudera.org:8080/16675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a446aa8d95a67658c727d3a6f85943d64c79ecf
Gerrit-Change-Number: 16675
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Mon, 02 Nov 2020 20:41:34 +0000
Gerrit-HasComments: Yes

Reply via email to